Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error ignore in compactor #34169

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

wayblink
Copy link
Collaborator

@wayblink wayblink commented Jun 25, 2024

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug do-not-merge/missing-related-issue labels Jun 25, 2024
Copy link
Contributor

mergify bot commented Jun 25, 2024

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@XuanYang-cn
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Jun 25, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (940a0ac) to head (4506df7).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34169      +/-   ##
==========================================
- Coverage   84.65%   81.00%   -3.66%     
==========================================
  Files         809     1077     +268     
  Lines      113143   137177   +24034     
==========================================
+ Hits        95779   111117   +15338     
- Misses      13147    21845    +8698     
+ Partials     4217     4215       -2     
Files Coverage Δ
...ternal/datanode/compaction/clustering_compactor.go 63.56% <0.00%> (-0.11%) ⬇️
internal/datanode/compaction/mix_compactor.go 70.89% <0.00%> (-3.87%) ⬇️

... and 299 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jun 26, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fbe3231 into milvus-io:master Jun 26, 2024
11 of 12 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
milvus-io#34170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
milvus-io#34170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
milvus-io#34170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
milvus-io#34170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 2, 2024
milvus-io#34170

Signed-off-by: wayblink <anyang.wang@zilliz.com>
czs007 pushed a commit that referenced this pull request Jul 3, 2024
This PR cherry-picks the following commits:

- fix: sync partitiion stats blocking balance task #33742
- fix: Fix meta prefix overlap bug #33830
- fix: Small fixs of major compaction #33929 
- fix: Fix memory buffer error & some renaming #33850
- fix: sync part stats task cannot be finished #34027 
- Add an option to enable/disable vector field clustering key #34097
- fix: fix error ignore in compactor #34169
- fix:load major compaction partial result #34052
- Use new stream segment reader in clustering compaction #34232

issue: #30633
pr: #33742 #33830 #33929 #33850 #34027 #34097 #34169 #34052 #34232

---------

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: Chun Han <116052805+MrPresent-Han@users.noreply.github.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants